Skip to content

Add Plan & Price Modeling PRD#4180

Open
Corw1n-of-Amber wants to merge 1 commit into
constructorfabric:mainfrom
Corw1n-of-Amber:add-plan-price-prd
Open

Add Plan & Price Modeling PRD#4180
Corw1n-of-Amber wants to merge 1 commit into
constructorfabric:mainfrom
Corw1n-of-Amber:add-plan-price-prd

Conversation

@Corw1n-of-Amber

Copy link
Copy Markdown

Summary

  • Adds a Plan & Price Modeling PRD under gears/bss/plan-price/docs/PRD.md, following the Constructor Studio gears/cf-bss format (17-section outline, cpt-cf-bss-plan-price-* IDs).
  • In scope: the catalog-side structure and publish contract for subscription plans — billing cycles (one-time/recurring/usage/hybrid/per-seat), price rows and model kinds (flat/graduated/volume/package), PriceWindow linkage and publish-time coverage, PriceList and customer-group segment pricing, plan phases, mandatory PlanTier, billing descriptors, fail-closed publish validation + two-person approval, versioning/retirement/migration, and the consumer read-model contracts (proration inputs, entitlement grant set, plan-change contract, pricingSnapshotRef).
  • Out of scope (delegated by reference): price evaluation/formulas/FX/coupons (Tariffs); subscription runtime, proration math, and PlanLink (Subscriptions); Product/SKU/Category/Attribute/CatalogVersion (Product & SKU registry); invoice posting and refunds (Billing/Payments); tax scheme + calculation (Tax Engine).

Validation

  • cfs validate --artifact gears/bss/plan-price/docs/PRD.md --skip-code --local-only → 0 errors, 0 warnings.
  • cfs validate-toc → all TOCs correct.

Signed-off-by: Mikhail Fedorov <mikhail.fedorov@virtuozzo.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • gears/bss/plan-price/docs/PRD.md
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4840b87e-6901-4b9a-8d40-83e0f1127e09

📥 Commits

Reviewing files that changed from the base of the PR and between 322a01f and 722ab48.

📒 Files selected for processing (1)
  • gears/bss/plan-price/docs/PRD.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dogbert2021

Copy link
Copy Markdown

we are reviewing SKU and Price Modeling and contact with the author, hopefully will resolve questions next week

@Artifizer
Artifizer requested a review from rostm July 10, 2026 11:04

@dogbert2021 dogbert2021 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with amendments:

  1. First-class includedAllowance - we need this to cover existing SKUs; for now we will have to cover this gap on CT facade / wrapper + OSS side

@Corw1n-of-Amber

Copy link
Copy Markdown
Author

approved with amendments:

  1. First-class includedAllowance - we need this to cover existing SKUs; for now we will have to cover this gap on CT facade / wrapper + OSS side

Agreed. First-class includedAllowance is already tracked as Future-scope — we kept the $0-first-band representation per the 2026-07-04 decision (recorded in Future scope + Open Questions), so nothing needs to change here to merge. Covering it on the CT facade/wrapper + OSS side for now makes sense. Noting the "needed for existing SKUs" demand — logged for the Plan & Price Design-phase agenda to revisit priority. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants