refactor(http-middleware): consolidate server-side HTTP middleware into shared crate#4173
Draft
mattgarmon wants to merge 1 commit into
Draft
refactor(http-middleware): consolidate server-side HTTP middleware into shared crate#4173mattgarmon wants to merge 1 commit into
mattgarmon wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…to shared crate Signed-off-by: matt.garmon <mjg2790@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4169
Move api-gateway's inbound HTTP middleware into the shared
cf-gears-toolkit-http-middleware crate so every HTTP-serving gear installs the
same layers from one place, and make those layers transport- and gear-agnostic.
toolkit-http-middleware:
mime_validation, license_validation, rate_limit, scope_enforcement, and
two-plane authentication (security_context + internal_auth).
GTS scope supplied by the consumer, so the crate carries no gear-specific
spec/config/error identity.
ScopeEnforcementConfig).
routers (explicit authenticated/public route sets with a require_auth_by_default
fallback), usable by any gear's HTTP edge.
toolkit-canonical-errors:
scoped_permission_denied, scoped_resource_exhausted) so shared middleware can
emit gear-scoped canonical errors without reaching a gear's #[resource_error]
type.
api-gateway:
AuthN SDK out of the shared crate), the gateway's GTS error scopes, and the
projection from OperationSpecs + config into the neutral middleware inputs.
RoutePoliciesConfig) so config lives with the middleware it configures.
docs:
README/rustdoc, and refresh cross-references to the relocated modules.
No behavior or wire-format change.