feat(export): add 6 new services_public settings tables to export#1083
Open
pyramation wants to merge 1 commit intomainfrom
Open
feat(export): add 6 new services_public settings tables to export#1083pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
Add database_settings, api_settings, rls_settings, cors_settings, pubkey_settings, and webauthn_settings to META_TABLE_CONFIG, META_TABLE_ORDER, exportMeta(), and exportGraphQLMeta(). These tables were added in constructive-db#1060 as part of the unified runtime settings architecture (constructive-planning#812).
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the 6 new
services_publicsettings tables (from constructive-db#1060) in the pgpm export system so they are included during database exports.Tables added:
database_settings,api_settings,rls_settings,cors_settings,pubkey_settings,webauthn_settingsFiles changed (all in
pgpm/export/src/):export-utils.ts— field configs inMETA_TABLE_CONFIG+ entries inMETA_TABLE_ORDERexport-meta.ts—queryAndParse()calls for SQL export flowexport-graphql-meta.ts—queryAndParse()calls for GraphQL export flowBoth export flows already handle missing tables gracefully (
42P01catch in SQL, field-not-found catch in GraphQL), so this is safe to merge before or after constructive-db#1060.Review & Testing Checklist for Human
META_TABLE_CONFIGfield types were derived from the deploy SQL, but any last-minute column changes in the schema PR would cause a mismatch. Cross-reference especially:rls_settingsuses_fnsuffixed columns (current_role_fn, etc.) andwebauthn_settings.challenge_expiry_secondsisbigintmapped to'int'.api_settingsnullable booleans — The DB columns are nullable (booleanwithoutNOT NULL) for inheritance semantics, but the config types them as'boolean'. ConfirmbuildDynamicFields()/mapPgTypeToFieldType()handles nullableboolcolumns correctly (the PGudt_nameisboolregardless of nullability, so this should be fine, but worth a sanity check).Notes
schemacolumn name used inpubkey_settingsandwebauthn_settingsis not a PostgreSQL reserved keyword but may warrant attention if it causes GraphQL inflection issues.Link to Devin session: https://app.devin.ai/sessions/94a2728a9c414500bead29cbbc829c15
Requested by: @pyramation