SceneAgbGhost: match fn_800A84A8#11
Open
LucasPicoli wants to merge 1 commit into
Open
Conversation
The animation index select compiled to srwi (logical shift), but the target uses srawi (arithmetic shift). Decoding `9 + srawi(neg(through),31)` shows the true value is 8, not 10: `through ? 8 : 9` yields the -1 mask that generates srawi and matches the original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anim-index select needs to be
through ? 8 : 9to emitsrawi(arithmetic shift) like the target — the10 : 9value producedsrwi.