Skip to content

docs(#239): replace broken policy source with local path in tutorial#241

Merged
st3penta merged 1 commit into
mainfrom
agent/239-fix-invalid-policy-source
Jul 9, 2026
Merged

docs(#239): replace broken policy source with local path in tutorial#241
st3penta merged 1 commit into
mainfrom
agent/239-fix-invalid-policy-source

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The "Validating arbitrary inputs" tutorial referenced a non-existent GitHub repository (github.com/acme/policy), causing users to get a "Repository not found" error when following the tutorial. Replace the git-based policy source with a local directory path to make the example self-contained and functional.


Closes #239

Post-script verification

  • Branch is not main/master (agent/239-fix-invalid-policy-source)
  • Secret scan passed (gitleaks — 38f47392e453bc90e8e2176be38bdeb44be4f3e1..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

The "Validating arbitrary inputs" tutorial referenced a non-existent
GitHub repository (github.com/acme/policy), causing users to get a
"Repository not found" error when following the tutorial. Replace the
git-based policy source with a local directory path to make the example
self-contained and functional.
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:29 AM UTC · Completed 10:33 AM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Verdict: Approve

Summary

Clean, well-scoped documentation fix that replaces a broken external policy source (git::https://github.com/acme/policy.git//policy?ref=prod) with a self-contained local directory path. The change directly addresses #239 where users following the "Validating arbitrary inputs" tutorial encountered a "Repository not found" error.

Changes reviewed

Dimension Assessment
Correctness ✅ The local policy path in policy.yaml correctly corresponds to the policy/signoff.rego file the tutorial asks users to create. The expected CLI output is updated consistently. Section reordering (rego file before policy.yaml) improves the tutorial flow — users create the policy rules before the configuration that references them.
Security ✅ No concerns — documentation-only change with no executable code, secrets, or access control implications.
Intent & coherence ✅ Directly addresses #239. Appropriately scoped — only the broken reference and its surrounding context are modified.
Style & conventions ✅ AsciiDoc formatting follows existing patterns. The NOTE admonition and block titles are correctly formatted.
Documentation currency ✅ This is the documentation fix itself. The added instructional text ("Create the following files in a working directory.") and the explanatory NOTE improve clarity.

Notes

  • The approach of using a local directory path makes the tutorial fully self-contained, which is a usability improvement over the original design (even if the git repo had existed).
  • The NOTE explaining that remote git URLs are also supported preserves the teaching value of the original example while keeping it functional.

Labels: PR fixes a documentation bug in the CLI tutorial page

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge bug Something isn't working documentation Improvements or additions to documentation labels Jul 9, 2026
@st3penta st3penta merged commit 6229407 into main Jul 9, 2026
9 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 1:47 PM UTC · Completed 1:57 PM UTC
Commit: 87c4a29 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

PR #241 on conforma/user-guide fixed a broken policy source URL in the CLI tutorial (issue #239). The pipeline worked end-to-end: triage ($0.51, 3 min), code agent ($5.70, 11 min), review agent ($0.42, 4 min), human approval 3 hours later with zero additional findings. The main inefficiency was in the code agent: its parent spawned a subagent with subagent_type 'code' which got an empty allowedTools array, wasting ~$2.50 and 80+ tool calls before the parent recovered by spawning with subagent_type 'claude'. This is tracked in fullsend-ai/fullsend#2098.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation ready-for-merge All reviewers approved — ready to merge size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid policy source in "ec validate input" tutorial

1 participant