chore: update fullsend shim workflow

[fullsend-ai-fullsend]

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 8:48 AM UTC · Completed 8:53 AM UTC
Commit: 7c8ccca · View workflow run →

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag	Coverage Δ
unit-tests	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fullsend-ai-review]

Review

Verdict: ⛔ Changes requested

This PR removes the Apache 2.0 license header (14 comment lines) from .github/workflows/fullsend.yaml to sync with an external template. While the intent is understandable, the removal will break CI and conflicts with the repo's universal license header convention.

Findings

🔴 Critical — CI will break: missing license header fails make lint

File: .github/workflows/fullsend.yaml, line 1

The Makefile lint target (lines 220–223) runs google/addlicense -check recursively on all files. The only exclusions are .git/** and .idea/** — there is no exclusion for fullsend.yaml. After this PR, the file starts with # lint-workflow-size: max-lines=280 with no license header. The pre-merge-ci.yaml workflow runs make ci (which includes make lint) on every PR targeting main. This will produce:

Missing license header in: .github/workflows/fullsend.yaml

Remediation: Either (1) keep the license header — ideally adding the missing # Copyright The Conforma Contributors line at the top to match all other workflow files, or (2) add -ignore '\.github/workflows/fullsend\.yaml' to LICENSE_IGNORE in the Makefile if this file should be exempt from license enforcement.

🟡 Medium — Convention deviation across all workflow files

File: .github/workflows/fullsend.yaml

All 8 other workflow files in .github/workflows/ carry the Apache 2.0 license header with # Copyright The Conforma Contributors and # SPDX-License-Identifier: Apache-2.0. Removing the header from this single file creates an inconsistency. The external template that this shim syncs to does not include the header, which means every future sync will re-create this conflict.

Remediation: Coordinate with the .fullsend template to either include the license header (preferred, since enrolled repos may have license enforcement) or explicitly exclude bot-managed shim files from license checks.

Notes

• Security: No concerns. The change is comment-only — no permissions, triggers, secrets, jobs, or steps are modified.
• Scope: This is a bot-authored PR with no linked issue. The mechanical nature of the sync is reasonable, but the license header removal specifically conflicts with repo policy and warrants human review (the requires-manual-review label is already applied).

---

📋 Review metadata

Dimension	Findings
Correctness	1 critical
Security	0
Intent & coherence	Covered in narrative
Style & conventions	1 medium
Docs currency	N/A (no docs changed)
Cross-repo contracts	N/A (no APIs changed)

Previous run

Review — comment

Summary

This PR removes the Apache 2.0 license header (14 comment lines) from .github/workflows/fullsend.yaml to sync with the upstream fullsend shim template. The workflow's functional YAML — permissions, triggers, jobs — is completely unchanged.

Findings

1. [medium] License header removal breaks CI lint check

File: .github/workflows/fullsend.yaml

The make lint target runs addlicense -check across all repo files (excluding only .git/** and .idea/**). Every other workflow file in .github/workflows/ carries the standard Apache 2.0 header with # Copyright The Conforma Contributors. Removing the header from this file causes the lint check to fail — confirmed by the all-tests-and-checks CI job, which has already concluded with failure on this PR's head commit.

Remediation: Either (a) re-add the license header (matching the # Copyright The Conforma Contributors format used by peer files), or (b) add -ignore '.github/workflows/fullsend.yaml' to the LICENSE_IGNORE variable in the Makefile if this file is intentionally template-managed and should be exempt. Option (a) is simpler and consistent with the rest of the repo; option (b) should be coordinated with the fullsend template so future syncs don't re-remove it.

Security

No security concerns. The change is comment-only and does not alter workflow permissions, triggers, job definitions, or any executable step.

Correctness

No functional impact. The YAML content below the removed header is identical before and after this change.

Previous run (2)

Review — comment

Summary

This PR removes the Apache 2.0 license header (14 lines, including the SPDX identifier) from .github/workflows/fullsend.yaml to sync the shim workflow with the upstream template in the .fullsend config repo.

The change is comment-only — no functional impact to the workflow definition. However, it conflicts with the repository's own license-header enforcement.

Findings

⚠ License header removal breaks CI lint check — medium

File: .github/workflows/fullsend.yaml

The repository enforces license headers on all files via addlicense -check (invoked by make lint, which is part of make ci). All 8 other workflow files in .github/workflows/ have the standard header:

# Copyright The Conforma Contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# ...
# SPDX-License-Identifier: Apache-2.0

Removing the header from fullsend.yaml causes the pre-merge-ci workflow to fail — the all-tests-and-checks job's "Run checks" step (make ci) is currently failing on this PR.

Remediation options:

1. Keep the license header — restore the removed block (and optionally add the missing Copyright The Conforma Contributors line to match the exact format used by other workflow files).
2. Exclude the file from addlicense — add -ignore '.github/workflows/fullsend.yaml' to the LICENSE_IGNORE variable in the Makefile if the intent is for this file to remain header-free and template-managed. This would need to be a deliberate project decision.

Dimensions reviewed

Dimension	Result
Correctness	✅ No issues — comment-only change, no logic affected
Security	✅ No issues — no changes to permissions, triggers, or secrets handling
Intent & coherence	⚠ Intent is clear (template sync), but conflicts with repo conventions
Style/conventions	⚠ License header inconsistency with all other workflow files; CI lint failure
Documentation	✅ No documentation impact
Cross-repo contracts	✅ No API or interface changes

---

Labels: PR modifies a GitHub Actions workflow file

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 3:12 PM UTC · Completed 3:16 PM UTC
Commit: 8f05d87 · View workflow run →

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 10:06 AM UTC · Completed 10:14 AM UTC
Commit: 87c4a29 · View workflow run →

[fullsend-ai-review]

See the review comment for full details.

[fullsend-ai-review]

[critical] CI breakage

Removing the Apache 2.0 license header will cause make lint to fail in CI. The Makefile lint target runs google/addlicense -check on all files (only .git/** and .idea/** are excluded). After this PR, fullsend.yaml has no license header, so addlicense will flag it as missing. The pre-merge-ci.yaml workflow runs make ci (which includes make lint) on every PR to main.

Suggested fix: Either keep the license header (adding the missing # Copyright The Conforma Contributors line to match other workflow files) or add -ignore .github/workflows/fullsend.yaml to LICENSE_IGNORE in the Makefile.