fix(#3360): add missing "go version" group to Renovate config#3361
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3360): add missing "go version" group to Renovate config#3361fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The org-level Renovate config excludes Go-related packages (golang, go-toolset Docker images and the go directive in go.mod) from the "docker images" and "go modules" groups, expecting them to be handled by a "go version" group — but that group rule was never defined. This caused Go version bump PRs to only update .tool-versions, leaving Dockerfile, Dockerfile.dist, and all go.mod files pinned to the old version. The review agent would flag the mismatch and the PRs would be autoclosed without merging. Add a packageRule in the repo-level renovate.json that groups all Go version dependencies (go, golang, docker.io/library/golang, registry.access.redhat.com/ubi9/go-toolset) under the "go version" groupName. This ensures Renovate updates all 7 files atomically in a single PR. Closes #3360
|
🤖 Finished Review · ✅ Success · Started 8:53 PM UTC · Completed 9:00 PM UTC |
|
Looks good to me. FindingsLow
Labels: PR modifies Renovate dependency management configuration for Go version grouping |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
It seems impossibly that the e2e failure is related to this PR. So I think we could disregard it rather than re-run. |
Contributor
|
we disabled golang updates in the org level config on purpose, because we wanted to have full control on that, and the renovate PRs were too much noise. I think we should close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The org-level Renovate config excludes Go-related packages (golang, go-toolset Docker images and the go directive in go.mod) from the "docker images" and "go modules" groups, expecting them to be handled by a "go version" group — but that group rule was never defined.
This caused Go version bump PRs to only update .tool-versions, leaving Dockerfile, Dockerfile.dist, and all go.mod files pinned to the old version. The review agent would flag the mismatch and the PRs would be autoclosed without merging.
Add a packageRule in the repo-level renovate.json that groups all Go version dependencies (go, golang, docker.io/library/golang, registry.access.redhat.com/ubi9/go-toolset) under the "go version" groupName. This ensures Renovate updates all 7 files atomically in a single PR.
Closes #3360
Post-script verification
agent/3360-renovate-go-version-group)76afa950a33babbf6b18ff2d9468c21d74ffe34e..HEAD)