fix: import ShowBoundaryValue from new reportlab location - #1
Open
yopiti wants to merge 1 commit into
Open
Conversation
reportlab moved ShowBoundaryValue from reportlab.platypus.frames to reportlab.pdfgen.canvas in the 4.4 line. Import it from the new location with a fallback to the old one for older reportlab, matching upstream. Unblocks reportlab>=4.4.3 (and svglib 2.0.2, which requires it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reportlab moved
ShowBoundaryValuefromreportlab.platypus.framestoreportlab.pdfgen.canvasin the 4.4 line, breakingfrom reportlab.platypus.frames import Frame, ShowBoundaryValueon reportlab>=4.4.3.This applies upstream's fix (try new location, fall back to old) on top of the currently-pinned commit (v0.2.13), as a minimal surgical change - avoiding pulling in 59 commits of upstream drift.
Unblocks bumping reportlab to 4.4+/5 and svglib to 2.0.2 in confdnt/backend.
Verified:
from xhtml2pdf import pisaimports cleanly under reportlab 4.5.1.