Skip to content

concepticon.tsv: SEMANTICFIELD Update#1535

Open
MiraAhmedovic wants to merge 3 commits into
masterfrom
SemanticField_Update
Open

concepticon.tsv: SEMANTICFIELD Update#1535
MiraAhmedovic wants to merge 3 commits into
masterfrom
SemanticField_Update

Conversation

@MiraAhmedovic

Copy link
Copy Markdown
Collaborator

Pull request checklist

  • add new concept list
  • add new metadata
  • add new Concepticon concept sets
    • checked whether the new concept(s) can be applied to existing lists with
      concepticon notlinked --gloss "NEW_GLOSS"
  • add new Concepticon concept relations
  • refine existing Concepticon concept set mappings
  • refine Concepticon glosses
  • refine Concepticon concept relations
  • refine Concepticon concept definitions
  • retire data

Additional information

As pointed out in #1521, there was some inconsistency regarding the SEMANTICFIELD of fruit and vegetables in our concepticon.tsv, since they were sometimes assigned "Food and drink" and "Agriculture and vegetation" in other cases.
This PR aims to resolve that inconsistency by assigning produce and unprocessed items (such as plants, fruit, vegetables or grains) to "Agriculture and vegetation" and processed foods (such as flour) to "Food and drink".

@LinguList LinguList left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants