Skip to content

docs: update sync-content README with undocumented features#87

Open
sonupreetam wants to merge 1 commit into
complytime:mainfrom
sonupreetam:docs/update-sync-content-readme
Open

docs: update sync-content README with undocumented features#87
sonupreetam wants to merge 1 commit into
complytime:mainfrom
sonupreetam:docs/update-sync-content-readme

Conversation

@sonupreetam

@sonupreetam sonupreetam commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Audited cmd/sync-content/README.md against the actual source code and found
several gaps and inaccuracies. This PR brings the documentation up to date:

  • New CLI Reference section — full table of all 13 flags with defaults and
    descriptions (--token, --output, --include, --exclude, --timeout
    were previously undocumented)
  • New Operational Details section — safety guards (zero-eligible-repo
    protection, path traversal blocking, config source governance validation),
    HTTP client behaviour (per-request timeout, response body limit, retry logic),
    and content processing edge cases (index.md skipping, intermediate section
    pages, empty language fallback, max scan depth, manifest carry-forward)
  • Fixed inaccurate provenance claim — "every synced file" → only
    config-declared files and auto-discovered doc pages; governance-generated
    _index.md/overview.md use frontmatter SHAs instead
  • Fixed diagram language count — 13 other Kroki-supported languages, not 12
  • Added missing Automation keyword"automation" alongside "automat"
  • Documented always-on transforms for config sync (stripLeadingH1,
    shiftHeadings, titleCaseHeadings are unconditional)
  • Added rewrite_diagrams to Configuration section and YAML example
  • Added diagram rewriting to Phase 1 steps (was missing)
  • Expanded GitHub Actions outputs — from 3 to all 6 variables in a table
  • Fixed CONTRIBUTING.md — corrected "tests mirror source files" to
    acknowledge helpers_test.go

No code changes — documentation only.

Test plan

  • Verified every claim against source code (main.go, transform.go,
    sync.go, hugo.go, config.go, github.go)
  • Review that new sections read clearly and are consistent with existing style

@sonupreetam sonupreetam requested a review from a team as a code owner July 7, 2026 14:17
Add CLI Reference section with all 13 flags, Operational Details
covering safety guards, HTTP client behaviour, and content processing
edge cases. Fix inaccurate provenance comment claim, diagram language
count, and Automation type keywords. Document always-on transforms for
config sync, rewrite_diagrams config key, and all 6 GitHub Actions
output variables. Update CONTRIBUTING.md test file description.

Signed-off-by: sonupreetam <spreetam@redhat.com>
@sonupreetam sonupreetam force-pushed the docs/update-sync-content-readme branch from d9ab5da to 02c7f40 Compare July 7, 2026 14:20

@trevor-vaughan trevor-vaughan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update looks fine.

Filed #88 as a general follow up to address maintenance confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants