Feat/add grav#1900
Conversation
Remove useless comments
Use fetch_and_deploy_gh_release
|
Hi @MickLesk and thanks for the review.
|
|
also please mark resolved conversations as resolved, thanks. |
|
Rest Look ok for me |
| { | ||
| "type": "default", | ||
| "script": "ct/grav.sh", | ||
| "config_path": "/opt/grav/user/config/site.yaml", |
There was a problem hiding this comment.
this is not restored after backup?
There was a problem hiding this comment.
Is null a valid value? I would rather have null if this field is just informative. I understood that it is not used anywhere.
There was a problem hiding this comment.
Tremor mean in CT/Grav.sh it will be erased and never backuped
There was a problem hiding this comment.
I was just rethinking that part. Grav has its own backup/restore mechanism and also upgrade from within the application. That is the recommended way of upgrading it and it works very well. If I simply restore the backup zip after replacing the /opt/grav, the website may not work at all.
Is it acceptable to just create the backup file or disable update at all?
There was a problem hiding this comment.
Then you need to remove the clean_install in CT and Show an hint with msg_custom (Look other Scripts), that use the build in updater
There was a problem hiding this comment.
So,
- create the backup file
- update the pat (/opt/grav)
- print a message to help restoring the backup?
Anyhow, I am gonna try to install an older version in the installer instead of latest, and then try to update
There was a problem hiding this comment.
Actually, I just tested the update command after hardcoding an older version.
Just removing CLEAN_INSTALL was enough. The website was preserved, with the pages, plugins and themes created/selected before the update. I am undoing that commit now.
To get back to the original point. I think I can leave the config_file as it is, or place null.
I just removed the CLEAN_INSTALL . @tremor021 @MickLesk
There was a problem hiding this comment.
If you remove the Clean Install and the project Maintainer Clean some npm/PHP/Go or something files in next updates it Break because the files stay in the folder and conflicted with newer Files. Thats the reason for Clean Install. Just Backup before, then Clean Install, then move Back after Clean install
There was a problem hiding this comment.
I have concerns about middling with the folders of the project after an upgrade. I would rather remove the fetch_and_deploy from the update script and use the recommended upgrade.
bin/gpm self-upgrade -y from https://learn.getgrav.org/17/cli-console/grav-cli-gpm#update
I am gonna try with another commit, but I think this is the safest way to go.
There was a problem hiding this comment.
I tested with self-upgrade. I could update from 1.7.51 to 1.7.52 with the update command inside the LXC container. I kept my website and plugins/themes.
The process provided by Grav itself, ensure also that dependencies are not broken and that if something will break, it will get disabled. That's a great advantage of this approach compared to just moving back things after installing a new version with CLEAN_INSTALL=1. I think this is the best approach to update the container software.
How does it look for you @MickLesk ?
Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.
✍️ Description
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🏗️ arm64 Support (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
Code_Audit.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)📋 Additional Information (optional)
I could not test the upgrade part, with the creation of the backup. It should hopefully also address community-scripts/ProxmoxVE#2124 later on, if it makes it to production.
This is adding the Grav CMS, better known as Grav
📦 Application Requirements (for new scripts)
🌐 Source