Skip to content

Submit/haproxy#1891

Draft
Hermandev07 wants to merge 3 commits into
community-scripts:mainfrom
Hermandev07:submit/haproxy
Draft

Submit/haproxy#1891
Hermandev07 wants to merge 3 commits into
community-scripts:mainfrom
Hermandev07:submit/haproxy

Conversation

@Hermandev07

@Hermandev07 Hermandev07 commented Jun 3, 2026

Copy link
Copy Markdown

Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review.

✍️ Description

This crates a Lxc that has HAproxy installed, it has a default config with a stats page at IP:8404, The config is /etc/haproxy/haproxy.cfg

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🏗️ arm64 Support (X in brackets)

  • arm64 supported - Tested and supported on arm64.
  • arm64 not tested - Assumed to work on arm64, but testing has not been done.
  • arm64 not supported - Confirmed upstream dependencies or binaries do not support arm64.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

image

📦 Application Requirements (for new scripts)

⚠️ Do not remove this section.
It is used by automated PR validation checks.
If this PR is not a new script submission, leave the checkboxes unchecked.

Required for 🆕 New script submissions.
Pull requests that do not meet these requirements may be closed without review.

  • The application is at least 6 months old
  • The application is actively maintained
  • The application has 600+ GitHub stars
  • Official release tarballs are published
  • I understand that not all scripts will be accepted due to various reasons and criteria by the community-scripts ORG

🌐 Source

https://github.com/haproxy/haproxy
https://www.haproxy.org/

@Hermandev07

Copy link
Copy Markdown
Author

@michelroegl-brunner

michelroegl-brunner commented Jun 3, 2026

Copy link
Copy Markdown
Member

Checking about the credentials. https://discord.com/channels/1302816934508630047/1304109415309512794/1511820004067119334

I dont really understand whats the issue here? That it has default credentials?
This would be no problem, we have some apps with default credentials.

Dont put the creds in console, and the warning belongs in the json notes, also not in the script.

@Hermandev07

Copy link
Copy Markdown
Author

Checking about the credentials. https://discord.com/channels/1302816934508630047/1304109415309512794/1511820004067119334

I dont really understand whats the issue here? That it has default credentials? This would be no problem, we have some apps with default credentials.

Dont put the creds in console, and the warning belongs in the json notes, also not in the script.

mostly that the credentials are just stored in plain text in the config file

@michelroegl-brunner

Copy link
Copy Markdown
Member

That is for all our scripts tbh. If a user is conserned it can be deleted. But we need to keep the same flow for all scripts, so not to tech savy users can follow allong.

@Hermandev07

Hermandev07 commented Jun 4, 2026

Copy link
Copy Markdown
Author

That is for all our scripts tbh. If a user is conserned it can be deleted. But we need to keep the same flow for all scripts, so not to tech savy users can follow allong.

gotcha, also you said "Dont put the creds in console" do you mean the proxmox host console after the lxc is made or the console of the lxc? right now i only show the creds in the host console after the script is made

This is the LXC console
image

@tremor021

Copy link
Copy Markdown
Member

He means this:

image

remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants