Conversation
Co-authored-by: Copilot <copilot@github.com>
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo to require/run on Node.js 24+ and adjusts CI + test dependencies to be compatible with newer Node/undici behavior.
Changes:
- Bump Node engine requirements to
>=24and align local tooling (.npmrc) + GitHub Actions to use Node 24. - Update MSW (and related lockfile entries) to a newer version.
- Adjust test setup and snapshots to accommodate Node/undici + mocked resources behavior.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates locked dependency versions (notably MSW + rettime) consistent with Node 24+ compatibility. |
| package.json | Raises root Node engine requirement to >=24. |
| .npmrc | Updates the pinned Node version used by tooling to 24.14.1. |
| packages/app-elements/package.json | Raises Node engine requirement to >=24 and bumps MSW dependency. |
| packages/docs/package.json | Raises Node engine requirement to >=24 and bumps MSW dependency. |
| packages/app-elements/src/mocks/stubs.ts | Adds a test-only workaround for AbortSignal/undici incompatibility in newer Node versions. |
| packages/app-elements/src/ui/forms/CodeEditor/fetchCoreResourcesSuggestions.test.ts | Updates assertions/snapshots for relationship suggestions. |
| .github/workflows/test.yaml | Runs CI tests on Node 24.x. |
| .github/workflows/publish.yaml | Runs publish workflow on Node 24.x. |
| .github/workflows/pkg-pr-new.yaml | Runs pkg-pr-new workflow on Node 24.x and changes how pkg-pr-new is invoked. |
| .github/workflows/gh-pages.yaml | Runs gh-pages workflow on Node 24.x. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/app-elements/src/ui/forms/CodeEditor/fetchCoreResourcesSuggestions.test.ts:1091
- The inline snapshot no longer includes
order.versions, but the test fixture for/api/public/resourcesstill includes theversionsrelationship onorder. This mismatch can hide whether the suggestion list changed intentionally vs. the tests drifting from the mocked schema; consider aligning by either updating the fixture/schema (ifversionsis truly gone) or restoring the snapshot entry.
},
{
"type": "relationship",
"value": "order.tags",
},
{
"type": "relationship",
"value": "order.event_stores",
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: |
pfferrari
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1116
What I did
How to test
Checklist