fix: add missing tool-input JSON schema#33
Merged
Conversation
The schemas/tool-inputs/ directory had JSON Schema files for 9 of the 12 onX tool inputs. Three were missing because they were not wired into the generator script: - create-return.json - get-returns.json - get-product-variants.json Added the corresponding imports and schema definition entries to generate-schemas.ts, then regenerated. All 12 tool-input schemas now have JSON Schema (draft-07) output alongside their Zod source definitions. Made-with: Cursor
ideaoforder
approved these changes
Mar 18, 2026
ideaoforder
left a comment
ideaoforder
left a comment
Collaborator
There was a problem hiding this comment.
This looks great! Much needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
schemas/tool-inputs/directory had JSON Schema files for 9 of the 12 onXtool inputs. Three were missing because they were not wired into the generator:
create-return.jsonget-returns.jsonget-product-variants.jsonChanges
server/src/schemas/utils/generate-schemas.ts: Added 3 imports and 3 entriesto
schemaDefinitionsschemas/tool-inputs/create-return.json: Generatedschemas/tool-inputs/get-returns.json: Generatedschemas/tool-inputs/get-product-variants.json: GeneratedTesting
Ran the schema generator and verified all 19 schemas (7 entities + 12 tool inputs)
generate without errors.