fix: omit server-generated fields from nested CustomerSchema in CreateSalesOrderInput#32
Merged
AJITHMELVIN merged 3 commits intoJun 4, 2026
Conversation
…eSalesOrderInput
CreateSalesOrderInputSchema omitted immutable fields (id, createdAt, updatedAt,
tenantId) from the top-level OrderSchema, but the nested CustomerSchema still
inherited them as required from ObjectProps. This caused AJV validation to reject
create-sales-order requests where customer was provided without createdAt,
updatedAt, or tenantId — fields that are server-generated and should never come
from the client.
Override the customer field to use CustomerSchema.omit({ createdAt, updatedAt,
tenantId }), keeping id for customer identification.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
timdauer
approved these changes
Mar 16, 2026
…dation/mcp-reference-server into fix/customer-schema-input
|
@timdauer Any updates on when you are planning to release it? |
AJITHMELVIN
approved these changes
Jun 4, 2026
AJITHMELVIN
left a comment
AJITHMELVIN
left a comment
Contributor
There was a problem hiding this comment.
reviewed on the grooming call, good to merge.
AJITHMELVIN
merged commit 02e193a
into
commerce-operations-foundation:develop
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateSalesOrderInputSchemaomits immutable fields (id,createdAt,updatedAt,tenantId) from the top-levelOrderSchema, but the nestedCustomerSchemastill inherited them as required fromObjectPropscreate-sales-orderrequests wherecustomerwas provided withoutcreatedAt/updatedAt/tenantId— fields that are server-generated and should never come from the clientcustomerfield to useCustomerSchema.omit({ createdAt, updatedAt, tenantId }), keepingidfor customer identificationTest plan
tsc --noEmit)create-sales-orderacceptscustomer: { id: "..." }withoutcreatedAt/updatedAt/tenantId🤖 Generated with Claude Code