DRYD-2102: Fixes for Thumbnail Derivative Generation#533
Open
mikejritter wants to merge 5 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
Open
DRYD-2102: Fixes for Thumbnail Derivative Generation#533mikejritter wants to merge 5 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
mikejritter wants to merge 5 commits intocollectionspace:upgrade/dryd-1633-core-updatesfrom
Conversation
f9114ad to
1c9913b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2102
When upgrading Nuxeo, changes were made to how their derivative generation works. This adds the necessary configuration so that the EventListener's which generate derivatives can run and submit the work items successfully.
logmanager-config.xml adds configuration for the Nuxeo Stream log. This currently uses the in memory implementation to avoid needing to deploy Kafka.
configuration-service-config.xml and the empty.png are required for the Event Listener which populates the views (derivatives) for an image. We could potentially add our own event listener which computes the views in order to avoid the requirement of the empty picture view property.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
Need to discuss with hosting about if we want to deploy Kafka or keep the in memory log manager.
Has the application documentation been updated for these changes?
No.
Did someone actually run this code to verify it works?
@mikejritter tested locally. It might be good to double check the blob integration tests as well to verify the generated images are correct.