Match spoken punctuation as whole words and stop auto-listing numbers#3
Merged
Merged
Conversation
The heuristic polisher replaced spoken marks (comma, colon, virgule, ...)
by plain substring search, so any word containing one was mangled:
"commande" became ", nde", "colonne" became ": ne", and so on for
colonel, colonie, colonisation. Match these marks only as whole words.
Also drop the numbered-list heuristic: it fired on any "1 <word>" and
reformatted every digit in the sentence onto its own line, so numbers
dictated in prose ("il y a 1 chien et 2 chats") turned into a list. On
speech input it produced almost only false positives.
Add regression tests for both.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two glitches in the heuristic polisher (the default
polish_backend, so this hits anyone dictating without Ollama):commande→, nde,colonne→: ne, and likewisecolonel,colonie,colonisation… (colon= English colon was the worst offender in French). Marks are now matched only as whole words, so dictatingcomma/virgulebetween two words still works.1 <word>and pushed every digit onto its own line —il y a 1 chien et 2 chatsbecame a list. On speech input it was almost only false positives, so the heuristic is dropped; numbers stay inline.Tests