Skip to content

Account for burnt CargoX tokens#8

Open
janezkranjc wants to merge 1 commit into
coincheckup:masterfrom
janezkranjc:master
Open

Account for burnt CargoX tokens#8
janezkranjc wants to merge 1 commit into
coincheckup:masterfrom
janezkranjc:master

Conversation

@janezkranjc

Copy link
Copy Markdown

CargoX burns tokens as part of its business model and token mechanics. In this PR I added logic that subtracts the burnt tokens (sent to 0x0 address) from the circulating supply.

@valentinbora

Copy link
Copy Markdown
Collaborator

@janezkranjc technically, the getTokenInfo Ethplorer method should provide the circulating supply already subtracting burnt coins (so I'm concerned about a potential update there, which might determine us to subtract twice). Do you think we should differentiate between circulating and available supply here?

In any case, both on Ethplorer and Etherscan, the circulating/available supply is updated manually AFAIK.

Let me know your thoughts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants