Skip to content

Abi changes coin5#635

Open
VolkerEnderlein wants to merge 4 commits into
coin-5from
ABI_changes_coin5
Open

Abi changes coin5#635
VolkerEnderlein wants to merge 4 commits into
coin-5from
ABI_changes_coin5

Conversation

@VolkerEnderlein

Copy link
Copy Markdown
Member

No description provided.

@veelo

veelo commented Jun 23, 2026

Copy link
Copy Markdown
Member

Since the only data in SbName is a const char*, this is more about style than anything else, right? And with these changes there will be two pointer dereferences, whereas now there is just one -- or can the compiler optimise that out? Maybe it is worth comparing the differences with godbolt.org.

@VolkerEnderlein

Copy link
Copy Markdown
Member Author

Thanks for reviewing the changes. The changes were purely motivated by making the API more coherent, as most but not all methods get SbName's passed by reference. I checked with godbolt.org, and in Release mode the references are optimized away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants