Fix Windows Release failures in DeepTreeEcho unit-test job#12
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Unit Tests - DeepTreeEcho
Fix Windows Release failures in DeepTreeEcho unit-test job
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Unit Tests - DeepTreeEcho (windows-latest, Release)Actions job failed due to Windows-specific portability/linkage issues in test code and ReservoirCpp shared-library linkage. This PR makes targeted cross-platform and CMake fixes to unblock that job.Windows portability fixes in unit tests
<chrono>includes in test files that usestd::chrono::high_resolution_clock.M_PIusage with a localconstexprPI constant inReservoirIntegrationTests.cpp.Windows shared-library link fix (ReservoirCpp)
WINDOWS_EXPORT_ALL_SYMBOLSforreservoircpp_corewhen building shared libraries on Windows.deep_tree_echo.Files touched
DeepTreeEcho/Testing/UnitTests/ActiveInferenceTests.cppDeepTreeEcho/Testing/UnitTests/ReservoirIntegrationTests.cppReservoirEcho/reservoircpp_cpp/CMakeLists.txtExample of the portability adjustment: