feat(Data Modeling, Files): Extend DM Files with all download methods#2653
feat(Data Modeling, Files): Extend DM Files with all download methods#2653haakonvt wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements file download and download URL retrieval capabilities (retrieve_download_urls, download, download_to_path, and download_bytes) for the data modeling files API in both async and sync clients. The feedback focuses on a potential breaking change introduced by renaming the nodes parameter to node_ids in the retrieve method of the data modeling files API. The reviewer recommends reverting this parameter name back to nodes across all overloads, implementation signatures, docstrings, and internal calls to maintain backward compatibility for keyword-argument callers.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-files-api-to-data-modeling #2653 +/- ##
==================================================================
- Coverage 93.08% 93.06% -0.02%
==================================================================
Files 489 489
Lines 49879 49911 +32
==================================================================
+ Hits 46428 46450 +22
- Misses 3451 3461 +10
🚀 New features to boost your workflow:
|
Part 2 out of 4.
PR stacked on #2647