Skip to content

feat(Data Modeling, Files): Extend DM Files with all download methods#2653

Open
haakonvt wants to merge 9 commits into
add-files-api-to-data-modelingfrom
add-dm-files-download
Open

feat(Data Modeling, Files): Extend DM Files with all download methods#2653
haakonvt wants to merge 9 commits into
add-files-api-to-data-modelingfrom
add-dm-files-download

Conversation

@haakonvt
Copy link
Copy Markdown
Contributor

@haakonvt haakonvt commented May 28, 2026

Part 2 out of 4.

PR stacked on #2647

@haakonvt haakonvt requested review from a team as code owners May 28, 2026 20:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements file download and download URL retrieval capabilities (retrieve_download_urls, download, download_to_path, and download_bytes) for the data modeling files API in both async and sync clients. The feedback focuses on a potential breaking change introduced by renaming the nodes parameter to node_ids in the retrieve method of the data modeling files API. The reviewer recommends reverting this parameter name back to nodes across all overloads, implementation signatures, docstrings, and internal calls to maintain backward compatibility for keyword-argument callers.

Comment thread cognite/client/_api/data_modeling/files.py
Comment thread cognite/client/_api/data_modeling/files.py
Comment thread cognite/client/_api/data_modeling/files.py
Comment thread cognite/client/_api/data_modeling/files.py
Comment thread cognite/client/_api/data_modeling/files.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.06%. Comparing base (a09f5dd) to head (2df4d92).

Files with missing lines Patch % Lines
cognite/client/_api/data_modeling/files.py 60.00% 4 Missing ⚠️
cognite/client/_sync_api/data_modeling/files.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           add-files-api-to-data-modeling    #2653      +/-   ##
==================================================================
- Coverage                           93.08%   93.06%   -0.02%     
==================================================================
  Files                                 489      489              
  Lines                               49879    49911      +32     
==================================================================
+ Hits                                46428    46450      +22     
- Misses                               3451     3461      +10     
Files with missing lines Coverage Δ
cognite/client/_api/files.py 94.08% <100.00%> (+0.15%) ⬆️
cognite/client/_sync_api/files.py 100.00% <100.00%> (ø)
tests/tests_integration/test_api/test_files.py 95.83% <100.00%> (+0.03%) ⬆️
cognite/client/_api/data_modeling/files.py 93.33% <60.00%> (-6.67%) ⬇️
cognite/client/_sync_api/data_modeling/files.py 87.87% <60.00%> (-12.13%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant