Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 3 unused import(s) (ruff F401/F811)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
8993e41 to
119d3b9
Compare
added 3 commits
June 13, 2026 03:44
…w with install scripts test_smoke.py was written against an older API (TECHNIQUES/parse_findings/ coverage_heatmap/lookup_technique/resolve_keywords) that no longer exists in core.py; updated every test to use the real current API (BY_ID, map_text, map_findings, map_files, lookup, tactic_coverage, navigator_layer) while preserving all assertions against real behavior. All 47 tests now pass. Added layman.md plain-language description, inserted What is this? and Install sections into README.md, and wrote install.sh plus install.ps1 covering pipx/uv/pip-git/source install paths.
- core.py: add scan()/to_json() aliases (required by mcp_server); guard map_files() against empty/whitespace paths; import json for to_json() - cli.py: validate --min-score >= 1 with a clear error; catch ValueError from map_files() in addition to OSError; handle KeyboardInterrupt/EOFError on stdin read - mcp_server.py: fix broken import (scan/to_json now exist in core); guard empty target in attackmap_scan tool; distinguish ImportError from other MCP import failures; handle app.run() exceptions - integrations/webhook.py: validate URL scheme (http/https only); reject empty URL and bare hostnames; validate --header format; reject empty stdin and non-JSON payloads; split HTTP/URL/Timeout error handling; fix E401 (multi-import on one line) - tests/test_hardening.py: 34 new tests covering all new error/edge paths - tests/test_smoke.py: remove unused imports (ruff F401)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.