feat: get_pass_chart returns the full chart layout (title, legend, meta) - #17
Merged
Merged
Conversation
The tool was reusing the OG social-card crop (bare circle). Add a option to renderPassChartSVG that paints the legend and keeps the title/ meta header, sky background, and watermark — a self-contained chart for agents, matching the on-screen modal. Also guard paintPolarModalLegend's browser-only `location.search` read so it renders server-side.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
coffee-converter
added a commit
that referenced
this pull request
Jul 3, 2026
The tool was reusing the OG social-card crop (bare circle). Add a option to renderPassChartSVG that paints the legend and keeps the title/ meta header, sky background, and watermark — a self-contained chart for agents, matching the on-screen modal. Also guard paintPolarModalLegend's browser-only `location.search` read so it renders server-side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_pass_chartMCP tool was reusing the OG social-card render, which is cropped to the bare circle (no title, legend, or date). For an agent receiving a standalone image, the full modal layout is more useful and matches what the website serves.renderPassChartSVGgains afulloption: paints the legend and keeps the title/meta header, sky background, and watermark (default stays cropped, so the OG card path is unchanged).get_pass_chartrequestsfull: trueand rasterizes at 800px.paintPolarModalLegendreadlocation.search(a?demoLegenddebug toggle) unconditionally, which threw during server-side render — now guarded withtypeof location !== 'undefined'.381/381 tests, typecheck + build clean. Verified by rendering a chart locally (title + Start/Peak/End times + legend + watermark all present).