fix: per-satellite magnitude (stop using the ISS brightness for everything) - #13
Merged
Merged
Conversation
magnitudeAt hardcoded m_std = -1.8 (the ISS), so every satellite got the ISS's brightness. Add a per-sat standardMag to the catalog and thread it through magnitudeAt -> peakMagnitudeInWindow / arc gradient, wired from the selected satellite in the scene and from the resolved entry in the MCP. Defaults to -1.8 so unthreaded callers are unchanged. Values (std mag, 1000km): ISS -1.8, Tiangong -1.0, BlueWalker 3 +0.5, Hubble +2.0, NOAA-19 +3.5.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
coffee-converter
added a commit
that referenced
this pull request
Jul 3, 2026
magnitudeAt hardcoded m_std = -1.8 (the ISS), so every satellite got the ISS's brightness. Add a per-sat standardMag to the catalog and thread it through magnitudeAt -> peakMagnitudeInWindow / arc gradient, wired from the selected satellite in the scene and from the resolved entry in the MCP. Defaults to -1.8 so unthreaded callers are unchanged. Values (std mag, 1000km): ISS -1.8, Tiangong -1.0, BlueWalker 3 +0.5, Hubble +2.0, NOAA-19 +3.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magnitudeAthardcodedm_std = -1.8— the ISS's standard magnitude — so Hubble/NOAA-19/BlueWalker 3 all reported the ISS's brightness (and the magnitude-driven polar-arc fade was wrong for them).standardMagto the catalog (ISS −1.8, Tiangong −1.0, BlueWalker 3 +0.5, Hubble +2.0, NOAA-19 +3.5 — approximate published standard magnitudes at 1000 km).magnitudeAt → peakMagnitudeInWindowand the polar-arc gradient; wired from the selected satellite in the scene and the resolved catalog entry in the MCP. Default −1.8 keeps unthreaded callers (e.g. OG render) unchanged.New
node:testcovers the param default + one-for-one stdMag shift + catalog sanity. 376/376 tests, typecheck + build clean.