Skip to content

feat/auth-google - #72

Open
DevOlabode wants to merge 7 commits into
mainfrom
feat/auth-google
Open

feat/auth-google#72
DevOlabode wants to merge 7 commits into
mainfrom
feat/auth-google

Conversation

@DevOlabode

Copy link
Copy Markdown
Member

Phase 3: Google — Backend adapter + Picker

One adapter behind the existing provider-neutral interface;

@DevOlabode DevOlabode self-assigned this Jul 20, 2026
@DevOlabode
DevOlabode requested a review from ieliofficial July 22, 2026 21:45
@DevOlabode DevOlabode closed this Jul 26, 2026
@DevOlabode
DevOlabode deleted the feat/auth-google branch July 26, 2026 23:55
@ieliofficial

Copy link
Copy Markdown
Member

Why was this closed? It's the whole Google Drive adapter, around 3800 lines, and it's only 2 commits behind main so it would still rebase cleanly.

The branch is deleted but the PR ref still has everything:

git fetch origin refs/pull/72/head:feat/auth-google

If it was closed because it wasn't finished, fine, but a closed PR with a deleted branch doesn't show up anywhere anyone actually looks. Can we either reopen it or open an issue with what's left? Otherwise we'll write it again in few weeks.

@DevOlabode
DevOlabode restored the feat/auth-google branch July 27, 2026 21:22
@DevOlabode DevOlabode reopened this Jul 27, 2026
@DevOlabode
DevOlabode force-pushed the feat/auth-google branch 2 times, most recently from 39ae78f to 20bc2ae Compare July 27, 2026 21:35
@ieliofficial

Copy link
Copy Markdown
Member

Can we rebase this one? It's ~47 commits behind main and GitHub can't work out whether it merges, so reviewing 3800 lines against a base from two weeks ago isn't going to be worth much.

Bigger question before either of us spends time on it: this adds Google sign in, but #111 asks to remove Google sign in because it isn't configured. Which way are we going? Happy to review properly once that's settled and it's rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants