feat/deleteindividual-scans - #113
Merged
Merged
Conversation
Implemented a new DELETE endpoint for removing saved scans from user storage. The ScanController now includes the deleteSavedScan method, which handles authentication, validates input, and interacts with the storage service to delete the specified scan. Updated the storageService to support scan deletion and added corresponding tests to ensure functionality and error handling. Frontend integration allows users to delete scans from the dashboard.
Added a new DELETE endpoint for removing saved scans from user storage, along with frontend integration in the DashboardView. Users can now confirm and delete scans, with appropriate error handling and UI updates. Updated documentation to reflect the new API capabilities and added tests to ensure functionality.
ieliofficial
approved these changes
Aug 13, 2026
ieliofficial
left a comment
ieliofficial
left a comment
Member
There was a problem hiding this comment.
Looks good. Follows the existing controller shape and the error mapping matches what the other routes do.
I specifically looked at whether the scan id could escape the scans directory, and it can't, since you match against the directory listing and build the path from the entry name rather than from user input. Good.
Heads up that this conflicts with #107 in storageService.js and its test file, so whichever lands second will need a rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.