Bug/depreciated error - #106
Conversation
ieliofficial
left a comment
ieliofficial
left a comment
There was a problem hiding this comment.
The actual fix is right and I checked that 2026-03-10 is a real version, GitHub 400s on a bogus one and accepts this. Forcing the header through request.defaults is the correct workaround for octokit 20 too.
The problem is it's about 20 lines of fix inside 120 lines of unrelated reformatting, and a couple of things got damaged on the way:
- the file header comment got flattened into run on lines with stray asterisks in the middle of sentences, compare it to main
- the trailing newline at the end of the file is gone
There's no prettier config in the repo, so the reflow is your editor's settings rather than a project standard, and it's what makes this conflict with #95 which rewrites the same function.
Can you drop the formatting changes and keep just the octokit factory plus the version constant? Would also be good to have a test asserting the header actually goes out on a request.
Separately, I don't think this closes #81 on its own, the repeated 404s on manifest lookups and the repo init noise are still open.
5f2760c to
ae5a7be
Compare
Use createGitHubOctokit so every client sends X-GitHub-Api-Version: 2026-03-10. Constructor request.headers is ignored by @octokit/rest@20. Assert the header is present on outgoing requests.
ae5a7be to
7434109
Compare
|
Addressed every requested change |
ieliofficial
left a comment
ieliofficial
left a comment
There was a problem hiding this comment.
Reformat is gone and the test actually asserts the header goes out on the wire. Good fix.
2 participants
Summary
Resolves the runtime logging issues identified in #81.
Changes
Related Issue: #81