Fix/improve nav ux - #105
Conversation
…w scan" button for authenticated users and improve accessibility with aria-labels
…maintain consistent header layout across routes
ieliofficial
left a comment
ieliofficial
left a comment
There was a problem hiding this comment.
The nav reorder itself looks good and the aria-label on nav is a nice addition.
But I think switching from inApp to authed && ... drops the New scan button for signed out users. results and problem have no auth guard in App.jsx, so anyone can scan without an account and land there, and they used to get the button. Now they won't.
It also affects signed in users who haven't connected storage yet, since App passes authed={authed && storageReady} into AppShell.
Could we keep the route check and add the auth one on top, something like (authed || route === 'results' || route === 'problem')?
AppShell was gating New scan on authed alone, which hides it for signed-out scanners and signed-in users without storage (App passes authed && storageReady). Show it when authed or on results/problem, still excluding signin/connect.
|
Addressed all requested changes |
ieliofficial
left a comment
ieliofficial
left a comment
There was a problem hiding this comment.
That's the case I was worried about. Comment explaining why results and problem are special is the useful part.
2 participants
Closes #103.
Changes the order on the nav bar as suggested in issue #103.
theme -> new scan button -> my scans button