Skip to content

Landing page open-enrollment redesign#171

Open
NickK21 wants to merge 2 commits into
mainfrom
NickK21/landing-page-update
Open

Landing page open-enrollment redesign#171
NickK21 wants to merge 2 commits into
mainfrom
NickK21/landing-page-update

Conversation

@NickK21
Copy link
Copy Markdown
Contributor

@NickK21 NickK21 commented May 1, 2026

Summary

  • updates the logged-out landing page to match the new Figma layout
  • adds the teacher account CTA linking to the Google Form in a new tab
  • adds the Join open-enrollment courses section to both logged-out and logged-in home views
  • shows all open-enrollment courses with course title, language, and ordered module names
  • adds language filtering and title/newest sorting for open-enrollment courses
  • preserves join intent through login and sends users into the student course view after joining
  • allows the landing-page data route to be accessed without authentication

Closes #157

@NickK21 NickK21 requested a review from DAC098 May 1, 2026 20:45
Copy link
Copy Markdown
Contributor

@DAC098 DAC098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit picks and questions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reasoning behind adding these back in. did you run into issues when working on this.

Comment on lines +134 to +145
{!user && <GuestLandingHeader />}

{user && (
<>
<HomeSection title="Instructing">
<InstructorCourseList courses={landingData.instructor} />
</HomeSection>
<HomeSection title="Attending">
<StudentCourseList courses={landingData.student} />
</HomeSection>
</>
)}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a ternary

Comment on lines +205 to +208
}: {
title: string,
children: JSX.Element,
}) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use PropsWithChildren to help with this

import {PropsWithChildren} from "react";

function HomeSection({title, children}: PropsWithChildren<{title: string}>) {
    return <div title={title}>{children}</div>;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

landing page update

2 participants