feat(cargo-agent): SQLX_OFFLINE, flock, test failure hints, --changed#4
Merged
Conversation
…action, --changed flag Port improvements from ai-barometer PR #154: - Default SQLX_OFFLINE=true with override support - Workflow-level flock to prevent concurrent cargo-agent runs - extract_failing_tests() parses nextest/libtest output for re-run hints - test --changed flag to scope tests to git-changed crates
![cadence[bot]](https://avatars.githubusercontent.com/in/2857168?s=60&v=4){kind=small}
![ai-barometer-staging[bot]](https://avatars.githubusercontent.com/u/205648601?s=60&v=4){kind=small}
Adds a cargo-agent scenario with a deliberately failing test to exercise the extract_failing_tests output (nextest FAIL lines, re-run hints).
…agents - Add tests/cargo-agent/flock/ scenario that holds the lockfile in a background process, launches cargo-agent, verifies the "waiting" message appears, then releases the lock and confirms completion. - Update add-x-agent.md with workflow-level lock as step 7 (flock on Linux, Perl fallback on macOS) — applicable to all agents. - Update contributing.md numbered list to include the new step. - Broaden shellcheck scan in CI and run-scenarios.sh to cover test scripts under tests/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLX_OFFLINE=trueby default, respecting explicit overrides (CI setsfalse)flock(Linux) or Perl fallback (macOS) to prevent concurrent cargo-agent runs from causing build-directory lock contentionfailures:summary sections; prints test names and/cargo-agent test <name>re-run commandstest --changedflag: Usesgit diff+ untracked files to detect changed crates and scope tests to only those packages; falls back to full suite for workspace-level Cargo file changesTest plan
bash -nsyntax check passesshellcheck --severity=warningpassestests/run-scenarios.sh cargo-agent)test --changedwith dirty working tree