Upgrade Fess dependency to version 15.3.2#12
Merged
Conversation
- Update fione version to 15.3.2-SNAPSHOT - Update fess-parent dependency to 15.3.2 - Migrate javax.* packages to jakarta.* for Java EE 9+ compatibility - javax.annotation.* → jakarta.annotation.* - javax.validation.* → jakarta.validation.* - javax.servlet.* → jakarta.servlet.* - javax.transaction-api → jakarta.transaction-api - Updated 10 Java source files with jakarta imports This upgrade aligns with Fess 15.x which requires: - Java 21 - OpenSearch 3.x - Tomcat 10.x (Jakarta EE 9+)
- Upgrade JDK from 17 to 21 (required for Fess 15.3.2) - Update GitHub Actions versions: checkout@v2→v4, setup-java@v2→v4, cache@v1→v4 - Add workflow_dispatch for manual workflow runs - Add timeout-minutes: 15 to prevent hanging builds - Add PARENT_BRANCH environment variable for fess-parent checkout - Add -Dgpg.skip=true to fess-parent installation - Add source:jar and javadoc:jar goals to build step - Keep ubuntu-latest runner (no macOS-specific requirements) Based on https://github.com/codelibs/fess/blob/master/.github/workflows/maven.yml
The deps.xml file attempts to download fione-serving 3.40.0.0-SNAPSHOT from a 2023-03-11 timestamp that is no longer available in the Sonatype snapshot repository, causing build failures: Can't get https://oss.sonatype.org/content/repositories/snapshots/ org/codelibs/fione/fione-serving/3.40.0.0-SNAPSHOT/ fione-serving-3.40.0.0-20230311.060953-1.jar This dependency should be managed through pom.xml dependencies instead of downloading via Ant script. Commented out the deps.xml call to allow builds to proceed. Fixes: mvn antrun:run build failure in GitHub Actions
In Fess 15.3.2, the org.codelibs.fess.Constants class constructor became private, preventing inheritance. Updated Constants to: - Remove inheritance from org.codelibs.fess.Constants - Add UTF_8_CHARSET and UTF_8 constants that were previously inherited - Use StandardCharsets.UTF_8 instead of custom Charset implementation - Keep all Fione-specific constants (REGRESSION_TYPE, MULTICLASS_TYPE, etc.) These constants are used throughout the codebase in: - DataSet.java - StringCodecUtil.java - ProjectHelper.java - PythonHelper.java - AdminEasymlAction.java Fixes: Constants() has private access in org.codelibs.fess.Constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrade aligns with Fess 15.x which requires: