Skip to content

Start GeoLocation only on iPhone and Android with GMS enabled#65

Merged
n3tr merged 1 commit into
masterfrom
check-hms-phonw
Jan 18, 2021
Merged

Start GeoLocation only on iPhone and Android with GMS enabled#65
n3tr merged 1 commit into
masterfrom
check-hms-phonw

Conversation

@n3tr

@n3tr n3tr commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

This version only remove the dialog "GMS unavailable" from the onboarding stage due to the lack of GMS on Huawei phone

This PR is similar to #56 but uses hasGMS detection function from react-native-device-info instead

@n3tr n3tr changed the title Check if the phone is ios and support GMS Start GeoLocation only if on iPhone and Android with GMS enabled Jan 18, 2021
@n3tr n3tr requested a review from Guutong January 18, 2021 14:03
@n3tr n3tr changed the title Start GeoLocation only if on iPhone and Android with GMS enabled Start GeoLocation only on iPhone and Android with GMS enabled Jan 18, 2021
@Guutong

Guutong commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

It works.
I Tested it On Huawei Y6p (HMS).

@n3tr n3tr added the bug Something isn't working label Jan 18, 2021
@n3tr n3tr merged commit e4ba9cc into master Jan 18, 2021
@PaperMonster

Copy link
Copy Markdown
Contributor

Podfile.lock should be updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants