Skip to content

Add support for no current library - #3430

Merged
sebjulliand merged 19 commits into
masterfrom
fix/crtdftLibProfile
Aug 31, 2026
Merged

Add support for no current library#3430
sebjulliand merged 19 commits into
masterfrom
fix/crtdftLibProfile

Conversation

@sebjulliand

Copy link
Copy Markdown
Member

Changes

Superseds #3396

This PR enables the user to remove the current library list (the equivalent of using CHGLIBL CURLIB(*CRTDFT)).
image

It adds a new "Remove Current Library" action in the library list view, on the Current library node.
image
image

Using a blank current library or *CRTDFT in a profile will result in having no current library as well.
image

How to test this PR

  1. Click on the "Remove current library" action
  2. Browse source files and open members
  3. Run an action
  4. Switch between profiles (one with and one without a current library)

Checklist

  • have tested my change

Closes #3383

buzzia2001 and others added 7 commits August 1, 2026 12:27
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
sebjulliand requested a review from a team August 28, 2026 06:50
@sebjulliand sebjulliand self-assigned this Aug 28, 2026
@sebjulliand sebjulliand added the enhancement New feature or request label Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

👋 A new build is available for this PR based on 42cf58d.

@sebjulliand sebjulliand mentioned this pull request Aug 28, 2026
1 task
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand

Copy link
Copy Markdown
Member Author

@buzzia2001 I fixed the two issues you raised previsouly:

  • Debug SBMJOB will receive CURLIB(*CRTDFT) when there's no current library
  • The &SRCFILE process has been changed a bit:
    • the streamfile will now be copied into a source file in QTEMP
    • we keep a link between the local file and the QTEMP file so the diagnostics get attached to the correct local file

sebjulliand

This comment was marked as resolved.

@buzzia2001

Copy link
Copy Markdown
Member

hi @sebjulliand,
I'm continuing with the testing... I found a bug...
Now, when you configure the profile, it marks the profile's libraries as not found... Here are the steps to reproduce it:

  1. Create a profile
image 2. activate it image 3. as you can see libraries ar marked as not found... but if you add another library using drag and drop from object browser, the list will be ok: image

I'm not sure if this bug is introduced by this PR, but I think it's worth fixing, don't you think?

Comment thread src/api/CompileTools.ts Outdated

@buzzia2001 buzzia2001 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, aside from the bug mentioned above, almost everything else seems fine to me, except for the profiles.

  • I tested the current library in the library list: OK
  • Current library in the profiles: FAIL
  • &CURLIB parameter in user actions: OK
  • &CURLIB parameter in actions from the local workspace (both DSPF and CL/RPG): OK
  • Test with SBMJOB for the debugger: OK

I’ve included some comments below, but here are a few concerns:

  • IBMi.ts has been modified, but when a new connection starts, it isn’t aware of the current library; since it can’t find one, *CRTDFT is used by default, but that’s incorrect. If a user has their own CURLIB, we should use that one
  • If I create a profile with any current library (BUZZI) and enter a command to change the library list, such as chgcurlib or chglibl, that sets the library list to *crtdft, I still see the current library (BUZZI)

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
… Library List Command.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand

Copy link
Copy Markdown
Member Author

Thanks for the review @buzzia2001.
I fixed everything you reported. The profiles needed a few fixes indeed.

I added a note in the description of the Curlib and Liblist field in the profile editor, warning that they'll be overwritten when the library list command is run.

image

Comment thread src/debug/index.ts Outdated
@buzzia2001
buzzia2001 self-requested a review August 30, 2026 21:09
@github-actions

Copy link
Copy Markdown
Contributor

👋 A new build is available for this PR based on b4e9060.

@buzzia2001 buzzia2001 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebjulliand, everything is working as I expected. Thank you so much for continuing to work on this PR and for the various fixes!

There is only a row that need to be removed, then feel free to merge

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
sebjulliand merged commit 3579db4 into master Aug 31, 2026
3 of 4 checks passed
@sebjulliand
sebjulliand deleted the fix/crtdftLibProfile branch August 31, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current Library special value *CRTDFT not supported

2 participants