Add support for no current library - #3430
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
👋 A new build is available for this PR based on 42cf58d. |
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
@buzzia2001 I fixed the two issues you raised previsouly:
|
|
hi @sebjulliand,
2. activate it
3. as you can see libraries ar marked as not found... but if you add another library using drag and drop from object browser, the list will be ok:
I'm not sure if this bug is introduced by this PR, but I think it's worth fixing, don't you think? |
There was a problem hiding this comment.
OK, aside from the bug mentioned above, almost everything else seems fine to me, except for the profiles.
- I tested the current library in the library list: OK
- Current library in the profiles: FAIL
- &CURLIB parameter in user actions: OK
- &CURLIB parameter in actions from the local workspace (both DSPF and CL/RPG): OK
- Test with SBMJOB for the debugger: OK
I’ve included some comments below, but here are a few concerns:
- IBMi.ts has been modified, but when a new connection starts, it isn’t aware of the current library; since it can’t find one, *CRTDFT is used by default, but that’s incorrect. If a user has their own CURLIB, we should use that one
- If I create a profile with any current library (BUZZI) and enter a command to change the library list, such as
chgcurliborchglibl, that sets the library list to*crtdft, I still see the current library (BUZZI)
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
… Library List Command. Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
Thanks for the review @buzzia2001. I added a note in the description of the Curlib and Liblist field in the profile editor, warning that they'll be overwritten when the library list command is run.
|
|
👋 A new build is available for this PR based on b4e9060. |
buzzia2001
left a comment
There was a problem hiding this comment.
Hi @sebjulliand, everything is working as I expected. Thank you so much for continuing to work on this PR and for the various fixes!
There is only a row that need to be removed, then feel free to merge
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>




Changes
Superseds #3396
This PR enables the user to remove the current library list (the equivalent of using

CHGLIBL CURLIB(*CRTDFT)).It adds a new "Remove Current Library" action in the library list view, on the Current library node.


Using a blank current library or

*CRTDFTin a profile will result in having no current library as well.How to test this PR
Checklist
Closes #3383