feat: add a showInTOC setting for the issue table of contents badge - #162
Merged
Conversation
nuest
marked this pull request as ready for review
August 13, 2026 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IssueTOCrendered its badge unconditionally, so a journal that turned off the CODECHECK article sidebar still got badges in issue listings with no way to stop them. The two displays are now controlled separately:showArticleSidebargoverns the article page,showInTOCthe badge.The defaults differ deliberately.
showInTOCtreats unset as "show", because the badge predates the setting and journals that never configure it should keep the behaviour they have;showArticleSidebarkeeps treating unset as "hide". The test dataset sets the sidebar explicitly and leavesshowInTOCalone, so the default-on path is the one exercised.Adds an e2e spec covering both states and that the setting does not disturb the article sidebar — verified to fail if
IssueTOCstops consulting it.The settings-form interaction the sidebar spec had grown moves into a
cy.setCodecheckSetting(fieldId, enabled)support command rather than being copied. Both specs restore what they change in anafter()hook.