refactor: remove the dead CodecheckMetadataDAO and schema.xml - #161
Merged
Conversation
nuest
marked this pull request as ready for review
August 13, 2026 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three files described the
codecheck_metadatatable and none of them agreed.version,publication_type,manifest,repository,source,codecheckers,certificate,issue,check_time,summary,report,additional_content.schema.xmldeclaredopt_in,code_repository,data_repository,dependencies,execution_instructions.CodecheckMetadataDAOqueriedidentifier,manifest_files,paper_metadata,repositories.Only the migration is real, so the other two are removed.
CodecheckMetadataDAOwas unreachable: nothing outside its own unit test referenced it, and every query would throw against the actual table — swallowed by a barecatchreturning null or an empty array, so a caller would have seen "no data" rather than an error.CodecheckSubmissionDAOis the live one.schema.xmlwas never loaded. OJS 3.5 installs plugin schemas throughgetInstallMigration(), which this plugin implements;Plugin::getInstallSchemaFile()is now afinal, empty stub a plugin cannot override.This drops the suite from 132 tests to 113. The 19 removed tests exercised the dead DAO against a mocked DB, so they passed while asserting nothing about code that could run.