[TASK] Supported TYPO3-10#514
Conversation
xperseguers
left a comment
xperseguers
left a comment
There was a problem hiding this comment.
It's totally unclear what this PR changes in regards to existing PR #292 where I already asked for changes which are not taken into account there either.
Please better comment for problems you may find either in PR #292 or (better imho) on my own v10 branch which takes PR #292 into account and fixes other problems as well: https://github.com/xperseguers/cf_google_authenticator/tree/feature/TYPO3v10
| <mrc:fal as="avatar" data="{user}" table="fe_users"> | ||
| <f:if condition="{avatar.0}"> | ||
| <f:then> | ||
| <button aria-label="{f:translate(extensionName: 'MrFelogin', id: 'sign_out')}" class="page-icon nav-link" name="submit"> |
There was a problem hiding this comment.
MrFeLogin has certainly nothing to do with that extension nor any extension in the core...
|
@codeFareith: Should be closed in favour of #518 |
|
I see little point of having yet another PR for supporting TYPO3 v10. Instead you should better open just a PR regarding adding French translation. And do not forget to create a ticket and not just a PR out of the blue :) |
2 participants
No description provided.