fix(auth): render gpt account login method selector - #1484
Closed
eddieparc wants to merge 3 commits into
Closed
Conversation
Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Owner
|
Closing as superseded by #1486 (merged as
This branch is also based 777 commits behind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectprompts in/gpt-account addwith the extension selectorbrowseranddevice_codeFixes #1483
Verification
bun run --cwd packages/coding-agent test test/suite/account-extension.test.tsbun run checktmuxSenpi TUI smoke (tui-smoke.mjs --self-test --driver tmux)No real OAuth, device code, or token was used.
Summary by cubic
Fixes
/gpt-account addso OAuth login method selection works correctly (fixes #1483), and adjusts credential pooling when adding a second account.Changes
selectprompts with the extension UI selector instead of the text-input adapter, which previously showed an empty field and returned an invalid method.browserordevice_code)./gpt-accountextension command for managing OpenAI Codex OAuth accounts (add, remove, pin, unpin, list).Written for commit 2a088da. Summary will update on new commits.