test(ai): select the copilot codex model dynamically in the tool-call-id handoff tests - #1356
Open
code-yeongyu wants to merge 1 commit into
Open
test(ai): select the copilot codex model dynamically in the tool-call-id handoff tests#1356code-yeongyu wants to merge 1 commit into
code-yeongyu wants to merge 1 commit into
Conversation
…-id handoff tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release-time typecheck keeps breaking on a retired github-copilot ModelId pin.
publish-npm.yml->scripts/release.mjsregenerates the model catalog live from models.dev, then runstsc. A test that passes a literal id intogetModel's ModelId parameter fails the moment upstream drops that id, even when the live test is skipIf-gated.This class of failure hit senpi on 2026-08-28 (
fireworks-models.test.ts:45) and again today: release run 33842146239 failed becausegpt-5.2-codexleft the live github-copilot catalog. #1353 unblocked 2026.9.4-2 by swapping the pin togpt-5.3-codex. That is still a literal pin, so the next retirement repeats the outage.What changed
packages/ai/test/tool-call-id-normalization.test.ts: the twogetModel("github-copilot", ...)pins (and the openrouteropenai/gpt-5.2-codexpins) now select a family match fromgetModels(...). No literal string flows intogetModel's ModelId parameter.github-copilot catalog has no codex-family model; update the test(and a sibling message for openrouter) instead of silently skipping.Verification
bunx tsc --noEmitexit 0 on the committed catalognpm --prefix packages/ai run generate-models(live) thenbunx tsc --noEmitexit 0; regen discardedbunx vitest run packages/ai/test/tool-call-id-normalization.test.tsgreen (2 passed, 4 skipIf'd without tokens)bunx biome check --error-on-warnings packages/ai/testexit 0node scripts/check-pr-changelog.mjs --base origin/mainexit 0 (test-only; no runtime source)Summary by cubic
Fixes release-time typecheck failures by selecting the Copilot Codex model dynamically in the tool-call-id handoff tests. The tests previously used hardcoded model IDs that would break when models.dev retired them; now they pick a codex-family model from the live catalog and throw a clear error if none exists.
Written for commit a0a43c5. Summary will update on new commits.