build(deps): bump symfony/polyfill-mbstring from 1.30.0 to 1.37.0#227
build(deps): bump symfony/polyfill-mbstring from 1.30.0 to 1.37.0#227dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [symfony/polyfill-mbstring](https://github.com/symfony/polyfill-mbstring) from 1.30.0 to 1.37.0. - [Release notes](https://github.com/symfony/polyfill-mbstring/releases) - [Commits](symfony/polyfill-mbstring@v1.30.0...v1.37.0) --- updated-dependencies: - dependency-name: symfony/polyfill-mbstring dependency-version: 1.37.0 dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
While this dependency update provides bug fixes and new functionality, it introduces significant environment requirements that must be verified before merging. Specifically, the minimum PHP version is raised to 7.2, and the ext-iconv extension is now mandatory.
Additionally, there is a metadata anomaly regarding a future timestamp ('2026-04-10') in the lock file and unnecessary diff noise due to the use of Composer 2.9.0. Although Codacy indicates the PR is up to standards, these environment-level risks should be addressed to prevent CI or deployment failures.
About this PR
- The upgrade increases the minimum PHP version requirement from 7.1 to 7.2 and adds a new mandatory requirement for 'ext-iconv'. Ensure that all production, staging, and CI environments (including Docker images) are updated to meet these requirements before merging.
Test suggestions
- Verify that the application's runtime and CI environments are running PHP 7.2 or higher.
- Verify that the 'ext-iconv' extension is installed and enabled in the PHP environment.
- Conduct regression tests on application modules that handle multibyte string manipulation (e.g. mb_strlen, mb_convert_encoding).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the application's runtime and CI environments are running PHP 7.2 or higher.
2. Verify that the 'ext-iconv' extension is installed and enabled in the PHP environment.
3. Conduct regression tests on application modules that handle multibyte string manipulation (e.g. mb_strlen, mb_convert_encoding).
Low confidence findings
- The 'time' metadata in 'composer.lock' for this package is set to a future date (2026-04-10). This is highly unusual and suggests the lock file may have been generated on a system with an incorrect clock.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| "ext-iconv": "*", | ||
| "php": ">=7.2" |
There was a problem hiding this comment.
🟡 MEDIUM RISK
This dependency update introduces a mandatory requirement for ext-iconv and bumps the minimum PHP version to 7.2. This is a breaking change for environments without the iconv extension or those still running on PHP 7.1.
| } | ||
| ], | ||
| "time": "2024-06-19T12:30:46+00:00" | ||
| "time": "2026-04-10T17:25:58+00:00" |
There was a problem hiding this comment.
⚪ LOW RISK
The 'time' field is set to a future date ('2026-04-10'). This metadata anomaly should be verified to ensure the lock file is not corrupted or generated with an incorrect system clock.
| "stability-flags": {}, | ||
| "prefer-stable": false, | ||
| "prefer-lowest": false, | ||
| "platform": [], | ||
| "platform-dev": [], | ||
| "plugin-api-version": "2.6.0" | ||
| "platform": {}, | ||
| "platform-dev": {}, | ||
| "plugin-api-version": "2.9.0" |
There was a problem hiding this comment.
⚪ LOW RISK
Nitpick: The lock file has been updated using Composer 2.9.0, which changed the internal format of stability-flags and platform from arrays to objects. This creates unnecessary diff noise and potential compatibility issues if the team or CI environment uses an older Composer version.
Bumps symfony/polyfill-mbstring from 1.30.0 to 1.37.0.
Release notes
Sourced from symfony/polyfill-mbstring's releases.
Commits
6a21eb9mbstring polyfills must not raise value errors in PHP 7f03734fCS fixes6d857f4minor #508 Require iconv for mbstring (jaapio)01072b6Require iconv for mbstring6c1cb6embstring: Fix mb_rtrim() for UTF-8 text2369cb9Give testing some love85181baBump to PHP 7.2, stick to phpunit 8.52bf2520fix function signature tests8740a07Improve mb_*trim polyfills74b87a0Mb trim functionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)