Remove stale ACTIVE_DEPLOYMENTS pinning from multicluster guide - #1194
Open
cortex-ai-agents[bot] wants to merge 1 commit into
Open
Remove stale ACTIVE_DEPLOYMENTS pinning from multicluster guide#1194cortex-ai-agents[bot] wants to merge 1 commit into
cortex-ai-agents[bot] wants to merge 1 commit into
Conversation
Signed-off-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com>
cortex-ai-agents
Bot
requested review from
KonstantinGasser,
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
September 7, 2026 06:24
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward documentation correction that cleanly aligns the guide with the already-updated script behavior.
Pull request overview
Updates the multicluster guide to match the current run.sh/Tilt behavior by removing a stale instruction to pin ACTIVE_DEPLOYMENTS before starting Tilt, aligning the documentation with Helm-values-driven deployment selection.
Changes:
- Removed
export ACTIVE_DEPLOYMENTS="nova" &&from the Tilt startup command in the multicluster guide.
File summaries
| File | Description |
|---|---|
| docs/guides/multicluster/readme.md | Removes stale ACTIVE_DEPLOYMENTS pinning so the Tilt startup steps reflect current guide automation and Helm values behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Test Coverage ReportTest Coverage 📊: 73.1% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run.sh script in docs/guides/multicluster was updated in #1190 to no longer pin ACTIVE_DEPLOYMENTS to "nova", but the readme still instructed users to set that env var before running tilt up. This removes the stale instruction so the guide matches the actual script behavior. Tilt now picks up whatever deployments are configured via the Helm values without needing the explicit env var.
Assisted-by: Claude Code:claude-sonnet-4-20250514 [Bash] [Read]