Fix multicluster recorder for controller-runtime v0.25.0 EventRecorder change - #1191
Merged
Merged
Conversation
…r change Signed-off-by: Philipp Matthes <p.matthes@sap.com>
PhilippMatthes
requested review from
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
September 4, 2026 09:19
KonstantinGasser
approved these changes
Sep 4, 2026
PhilippMatthes
deleted the
fix/controller-runtime-v0.25-event-recorder
branch
September 4, 2026 09:23
Contributor
Test Coverage ReportTest Coverage 📊: 73.1% |
juliusclausnitzer
added a commit
that referenced
this pull request
Sep 7, 2026
## Release cortex v0.4.1, cortex-shim v0.1.17 ### cortex-shim v0.1.17 (sha-cd38777a) New features: - Remote apiserver liveness probe — adds a per-remote reachability probe (`GET /readyz`) that detects when a remote apiserver becomes unreachable after its informer cache has synced; after a configurable failure threshold (default 3 × 10s), the probe cancels the manager cycle context so the existing self-healing supervisor rebuilds the manager with current config (#1190) - `cortex_multicluster_remote_apiserver_reachable{host}` gauge — exposes per-remote apiserver reachability on the process-lifetime monitor, surviving manager rebuilds (#1190) - `CortexPlacementShimRemoteApiserverUnreachable` alert — fires when a remote apiserver is unreachable (#1190) Non-breaking changes: - Fix multicluster recorder for controller-runtime v0.25.0 `EventRecorder` interface change — adds `AnnotatedEventf` method to `MultiClusterRecorder` to satisfy the wider `recorder.EventRecorder` interface (#1191) - Update `sigs.k8s.io/controller-runtime` to v0.25.0 (#1188) - Update `sigs.k8s.io/controller-tools` to v0.22.0 (CRD annotation bump) (#1186) - Update `github.com/sapcc/go-bits` (#1187) - Update `kube-prometheus-stack` to v89 (#1189) ### cortex v0.4.1 (sha-cd38777a) Non-breaking changes: - Fix multicluster recorder for controller-runtime v0.25.0 `EventRecorder` interface change (#1191) - CRDs regenerated with controller-tools v0.22.0 (#1186) - Update `sigs.k8s.io/controller-runtime` to v0.25.0 (#1188) - Update `github.com/sapcc/go-bits` (#1187) ### cortex-placement-shim v0.1.17 Includes updated chart cortex-shim v0.1.17. ### cortex-nova v0.0.90 Includes updated chart cortex v0.4.1. ### cortex-cinder v0.0.90 Includes updated chart cortex v0.4.1. ### cortex-manila v0.0.90 Includes updated chart cortex v0.4.1. ### cortex-crds v0.0.90 Includes updated chart cortex v0.4.1. ### cortex-ironcore v0.0.90 Includes updated chart cortex v0.4.1. ### cortex-pods v0.0.90 Includes updated chart cortex v0.4.1. --- ### Chart bumps | Chart | Previous | New | |---|---|---| | `cortex` (library) | `0.4.0` / `sha-91df27a0` | `0.4.1` / `sha-cd38777a` | | `cortex-shim` (library) | `0.1.16` / `sha-b577e306` | `0.1.17` / `sha-cd38777a` | | `cortex-placement-shim` (bundle) | `0.1.16` | `0.1.17` | | `cortex-nova` (bundle) | `0.0.89` | `0.0.90` | | `cortex-cinder` (bundle) | `0.0.89` | `0.0.90` | | `cortex-manila` (bundle) | `0.0.89` | `0.0.90` | | `cortex-crds` (bundle) | `0.0.89` | `0.0.90` | | `cortex-ironcore` (bundle) | `0.0.89` | `0.0.90` | | `cortex-pods` (bundle) | `0.0.89` | `0.0.90` | No bumps for: cortex-postgres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping sigs.k8s.io/controller-runtime to v0.25.0 changed the return type of cluster.Cluster.GetEventRecorder from k8s.io/client-go/tools/events.EventRecorder to sigs.k8s.io/controller-runtime/pkg/recorder.EventRecorder, which embeds both events.EventRecorder and events.AnnotatedEventRecorder. This broke the build in pkg/multicluster.
This updates the multicluster Client, MultiClusterRecorder, and their test doubles to use the new recorder.EventRecorder type, and adds an AnnotatedEventf method that routes annotated events to the correct cluster recorder just like Eventf does, so the recorder satisfies the wider interface. make passes locally with lint and all tests green.
Assisted-by: Claude Code:claude-opus-4-8 [Bash] [Read]