fix(mobile): consolidate live-round bottom chrome (5 stacked pills → 3 layers) - #830
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
Generated by Claude Code |
cner-smith
force-pushed
the
fix/live-chrome-consolidation
branch
from
August 7, 2026 21:35
dbfc016 to
8a9c76d
Compare
… to one chip row, drop duplicate GPS hint
…t precisely (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA (SDK 54 internal track): the live PLACE_BALL state stacked 5 elements over the map — primary CTA, "On the green" chip, a GPS drag hint, "Finish hole" chip, and the nav pill ([screenshot in QA thread]). Launch-blocking per user.
Changes (ContextualActions PLACE_BALL block only)
Result: CTA / chip row / nav pill — 3 layers. Behavior gates unchanged: on-green chip keeps its phantom-ace gate (prior shot + ball/GPS + not saving); finish chip keeps
totalShotsThisHole > 0; both now render inside one row gated on the shared condition. On-green (PUTTING) state untouched.Stacked on
fix/green-putt-overlays(#826) — this file's future shape lives there. Merge #826 first, then this (do NOT delete the base branch before this merges).Typecheck clean. Device QA: same pass as #826 (one live hole: mark ball, on-green chip works, finish hole works, no hint pill, chip row wraps nothing at 1.3x font cap).