ci(sessionize-new-proposal): deny-all permissions on the default token#734
Open
arpitjain099 wants to merge 1 commit into
Open
ci(sessionize-new-proposal): deny-all permissions on the default token#734arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The retrieve-latest-session job only hits the Sessionize public API and the Slack webhook. The update-github-variable job uses secrets.REPO_ACCESS_TOKEN to mutate the repo variable, not the default GITHUB_TOKEN. Workflow has no checkout step. Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
e5bb05c to
c9a79a0
Compare
Author
|
Hi @AudMonte01, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
permissions: {}(deny-all) to the scheduled Sessionize sync workflow. The defaultGITHUB_TOKENis unused:retrieve-latest-sessionjob calls the Sessionize public API and the Slack webhook viaSLACK_WEBHOOK_URL— no GitHub API calls.update-github-variablejob usesmmoyaferrer/set-github-variablewithsecrets.REPO_ACCESS_TOKEN, a separate PAT, not the default token.YAML validated locally.