Skip to content

Skip tests for manylinux_aarch64 builds#348

Merged
nsmith- merged 1 commit into
masterfrom
lwtnn-aarch64-skip
Jun 16, 2026
Merged

Skip tests for manylinux_aarch64 builds#348
nsmith- merged 1 commit into
masterfrom
lwtnn-aarch64-skip

Conversation

@nsmith-

@nsmith- nsmith- commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

As we see small floating point rounding discrepancies in lwtnn on this platform. Related to #35

In the wheel build on ubuntu-24.04-arm for we have a test failure:

[3](https://github.com/cms-nanoAOD/correctionlib/actions/runs/27582720385/job/81546393204#step:3:2624)
  =================================== FAILURES ===================================
  ______________________________ test_lwtnn_example ______________________________
  
      def test_lwtnn_example():
          cset = CorrectionSet.from_file(str(LWTNN_TEST_FIXTURE))
          corr = cset["electron_fastsim_sf"]
      
          gen_pt = 15.0
          gen_eta = 0.4
          gen_phi = 2.1
          gen_iso = 1e-3
          sf = corr.evaluate(
              gen_pt,
              gen_eta,
              gen_phi,
              gen_iso,
          )
  >       assert sf == 0.95186825355646787
  E       assert 0.9518682535564678 == 0.9518682535564679
  
  /project/tests/test_lwtnn.py:41: AssertionError

so it seems lwtnn is sensitive to platform-dependent float rounding.

As we see small floating point rounding discrepancies in lwtnn on this platform
@nsmith- nsmith- changed the title Skip tests for manylinug_aarch64 builds Skip tests for manylinux_aarch64 builds Jun 16, 2026
@nsmith- nsmith- enabled auto-merge June 16, 2026 13:23
@nsmith- nsmith- added this pull request to the merge queue Jun 16, 2026
@github-actions

Copy link
Copy Markdown

CVMFS benchmarks

Top 25 slowest-loading corrections, sorted by mean time:

Benchmark Mean (ms) Stddev (ms) Rounds
test_load[JME/Run2-2017-UL-NanoAODv9/latest/jet_jerc.json.gz] 1005.297 3.888 5
test_load[JME/Run2-2017-UL-NanoAODv9/latest/fatJet_jerc.json.gz] 836.191 8.413 5
test_load[JME/Run3-24Prompt-Winter24-NanoAODv14/latest/jet_jerc.json.gz] 697.693 2.872 5
test_load[JME/Run3-24CDEReprocessingFGHIPrompt-Summer24-NanoAODv15/latest/fatJet_jerc.json.gz] 618.594 2.659 5
test_load[JME/Run3-24CDEReprocessingFGHIPrompt-Summer24-NanoAODv15/latest/jet_jerc.json.gz] 615.113 1.886 5
test_load[JME/Run3-25Prompt-Winter25-NanoAODv15/latest/fatJet_jerc.json.gz] 418.594 1.600 5
test_load[JME/Run3-25Prompt-Winter25-NanoAODv15/latest/jet_jerc.json.gz] 417.577 1.390 5
test_load[JME/Run2-2018-UL-NanoAODv9/latest/jet_jerc.json.gz] 334.098 2.434 5
test_load[JME/Run3-23CSep23-Summer23-NanoAODv12/latest/fatJet_jerc.json.gz] 333.706 2.467 5
test_load[JME/Run3-23CSep23-Summer23-NanoAODv12/latest/jet_jerc.json.gz] 329.674 0.501 5
test_load[JME/Run2-2016preVFP-UL-NanoAODv9/latest/jet_jerc.json.gz] 273.660 0.930 5
test_load[JME/Run2-2018-UL-NanoAODv9/latest/fatJet_jerc.json.gz] 259.699 1.441 5
test_load[JME/Run3-22EFGSep23-Summer22EE-NanoAODv12/latest/jet_jerc.json.gz] 259.174 0.990 5
test_load[JME/Run3-22EFGSep23-Summer22EE-NanoAODv12/latest/fatJet_jerc.json.gz] 256.966 0.944 5
test_load[JME/Run2-2016postVFP-UL-NanoAODv9/latest/jet_jerc.json.gz] 250.602 1.373 5
test_load[JME/Run3-23DSep23-Summer23BPix-NanoAODv12/latest/jet_jerc.json.gz] 242.207 2.041 5
test_load[JME/Run3-23DSep23-Summer23BPix-NanoAODv12/latest/fatJet_jerc.json.gz] 241.255 0.718 5
test_load[JME/Run2-2016preVFP-UL-NanoAODv9/latest/fatJet_jerc.json.gz] 236.777 0.321 5
test_load[JME/Run2-2017-UL-NanoAODv15/latest/jet_jerc.json.gz] 234.417 1.882 5
test_load[JME/Run2-2017-UL-NanoAODv15/latest/fatJet_jerc.json.gz] 232.670 0.549 5
test_load[JME/Run2-2018-UL-NanoAODv15/latest/fatJet_jerc.json.gz] 223.637 1.125 5
test_load[JME/Run2-2016postVFP-UL-NanoAODv9/latest/fatJet_jerc.json.gz] 223.064 1.879 5
test_load[JME/Run2-2018-UL-NanoAODv15/latest/jet_jerc.json.gz] 222.458 0.710 5
test_load[JME/Run3-22Prompt-Winter22-NanoAODv12/latest/fatJet_jerc.json.gz] 220.530 3.449 5
test_load[JME/Run3-22Prompt-Winter22-NanoAODv12/latest/jet_jerc.json.gz] 218.865 0.427 5

Merged via the queue into master with commit 23c0eee Jun 16, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant