Sns migration to AWS Sdk V2 - first draft#1
Open
cmachgodaddy wants to merge 2 commits into
Open
Conversation
iemejia
reviewed
Jul 24, 2019
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
Looking good so far. Let some minor comments
| import software.amazon.awssdk.services.sns.model.PublishResponse; | ||
|
|
||
| /** Custom Coder for handling publish result. */ | ||
| public class PublishResultCoder extends Coder<PublishResponse> implements Serializable { |
| kafka_clients : "org.apache.kafka:kafka-clients:$kafka_version", | ||
| malhar_library : "org.apache.apex:malhar-library:$apex_malhar_version", | ||
| mockito_core : "org.mockito:mockito-core:1.10.19", | ||
| mockito_core : "org.mockito:mockito-core:2.8.47", |
There was a problem hiding this comment.
don't change this one, do it in the AWS2 build gradle file and with version 2.3.0
cmachgodaddy
pushed a commit
that referenced
this pull request
Aug 21, 2019
It turned out we tested nothing relevant with the additional 2 tests that are deleted. The Combine test maps values of different sizes to Long value. The deleted tests had only different initial size so, in practice, they were testing the same thing as test #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
[
[
[
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.