fix: upgrade sonic loader for go1.26#15
Merged
liuq19 merged 1 commit intocloudwego:mainfrom Apr 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades module dependencies to ensure sonic/loader works correctly at runtime on Go 1.26 (notably for darwin/amd64 native path), while refreshing the module sums and related test dependencies.
Changes:
- Bump
github.com/bytedance/sonic/loaderfromv0.3.0tov0.5.1. - Update
github.com/stretchr/testifytov1.10.0and refreshgo.sumentries (including transitive test deps).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates direct dependency versions for sonic/loader and testify. |
| go.sum | Refreshes sums to match the updated module graph (including updated objx and testify entries). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
liuq19
force-pushed
the
fix/loader-go126
branch
4 times, most recently
from
2ab1e5d to
18eea7b
Compare
liuq19
force-pushed
the
fix/loader-go126
branch
from
18eea7b to
44afa73
Compare
| strategy: | ||
| matrix: | ||
| go: [ 1.17.x, 1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x] | ||
| go: [ 1.17.x, 1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x, 1.24.x, 1.25.x, 1.26.x] |
AsterDY
approved these changes
Apr 29, 2026
GuangmingLuo
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/bytedance/sonic/loaderfromv0.3.0tov0.5.1.benchmodule.1.17.xthrough1.26.x.Motivation
sonic/loader v0.3.0can compile with Go 1.26 in the amd64 native path, but it fails at runtime during loader initialization. On darwin/amd64 with Go 1.26.0, the native tests fail inruntime.moduledataverify1with:sonic/loader v0.5.0added upstream Go 1.26 support, andv0.5.1is the latest loader tag.Validation
GOTOOLCHAIN=go1.26.0 GOOS=darwin GOARCH=amd64 CGO_ENABLED=0 go test -run 'TestEncoder|TestDecoder|TestSubrCompatibilitySymbols' -count=1 -v .GOTOOLCHAIN=go1.26.0 CGO_ENABLED=0 go test ./...GOTOOLCHAIN=go1.26.0 go test -bench=. -benchmem -run=none ./...inbench/GOTOOLCHAIN=go1.25.5 CGO_ENABLED=0 go test ./...GOTOOLCHAIN=go1.24.10 CGO_ENABLED=0 go test ./...git diff --checktypos