fix(java): simplify NodeID name to methodName(paramTypes)#189
Open
wzekin wants to merge 2 commits intocloudwego:mainfrom
Open
fix(java): simplify NodeID name to methodName(paramTypes)#189wzekin wants to merge 2 commits intocloudwego:mainfrom
wzekin wants to merge 2 commits intocloudwego:mainfrom
Conversation
Java method NodeIDs were using the JAR-provided Descriptor/RawText directly, which often included modifiers, return type, throws clause, parameter names and annotations. Rebuild the name from MethodDetail's parameter list (TypeRawText, falling back to TypeFqcn) so NodeIDs are stable and concise — e.g. queryJwtToken(String,String,String).
GetName() only splits Descriptor at '(' so when the JAR returns the
long form (e.g. "abstract void foo()"), modifiers and return type
leaked into the NodeID name. Take the last whitespace-delimited token
after GetName(), and drop empty parens for no-arg methods so the
exported "Class.method" form stays clean.
wzekin
force-pushed
the
fix/java-nodeid-simplify
branch
from
9fbf3dd to
6eecc8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java method NodeIDs were using the JAR-provided Descriptor/RawText directly, which often included modifiers, return type, throws clause, parameter names and annotations. Rebuild the name from MethodDetail's parameter list (TypeRawText, falling back to TypeFqcn) so NodeIDs are stable and concise — e.g. queryJwtToken(String,String,String).
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
优化前：
优化后：
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: