Skip to content

Fix some bad .End usages in parser.go - #150

Merged
makenowjust merged 1 commit into
mainfrom
fix-some-end
Oct 20, 2024
Merged

Fix some bad .End usages in parser.go#150
makenowjust merged 1 commit into
mainfrom
fix-some-end

Conversation

@makenowjust

Copy link
Copy Markdown
Collaborator

Related to #149

  • This fixes GeneratedColumnExpr.End(), and now Stored points to the head position of the STORED token.
  • ArraySchemeType.Gt points to the head position of the > token.

Ref #149

- This fixes `GeneratedColumnExpr.End()` and now `Stored` points to the
  head position of the `STORED` token.
- `ArraySchemeType.Gt` points to the head position of the `>` token.

@apstndb apstndb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a reviewer, but LGTM!
I will resolve conflict #111 with this PR after merge

@makenowjust
makenowjust merged commit 82b9d09 into main Oct 20, 2024
@makenowjust
makenowjust deleted the fix-some-end branch October 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants