Skip to content

chore: Fix reset table column size test #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jperals wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Fix reset table column size test #4694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/table/__integ__/resizable-columns.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
}

async assertColumnWidth(columnIndex: number, expected: number) {
await this.browser.waitUntil(async () => (await this.getColumnWidth(columnIndex)) === expected, {

Check failure on line 124 in src/table/__integ__/resizable-columns.test.ts

View workflow job for this annotation

GitHub Actions / dry-run / Components integration tests shards (React 16, shard 3/4)

should recover column widths when the inner state is reset 

Column at index "2" should have width "130"

    at node_modules/webdriverio/build/node.js:6083:15
    at Browser.wrapCommandFn (node_modules/@wdio/utils/build/index.js:982:23)
    at TablePage.assertColumnWidth (src/table/__integ__/resizable-columns.test.ts:124:5)
    at src/table/__integ__/resizable-columns.test.ts:347:5
    at src/table/__integ__/resizable-columns.test.ts:150:5
    at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)

Check warning on line 124 in src/table/__integ__/resizable-columns.test.ts

View workflow job for this annotation

GitHub Actions / dry-run / Components integration tests shards (React 16, shard 3/4)

RETRY 3: should recover column widths when the inner state is reset 

Column at index "2" should have width "130"

    at node_modules/webdriverio/build/node.js:6083:15
    at Browser.wrapCommandFn (node_modules/@wdio/utils/build/index.js:982:23)
    at TablePage.assertColumnWidth (src/table/__integ__/resizable-columns.test.ts:124:5)
    at src/table/__integ__/resizable-columns.test.ts:347:5
    at src/table/__integ__/resizable-columns.test.ts:150:5
    at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)

Check warning on line 124 in src/table/__integ__/resizable-columns.test.ts

View workflow job for this annotation

GitHub Actions / dry-run / Components integration tests shards (React 16, shard 3/4)

RETRY 2: should recover column widths when the inner state is reset 

Column at index "2" should have width "130"

    at node_modules/webdriverio/build/node.js:6083:15
    at Browser.wrapCommandFn (node_modules/@wdio/utils/build/index.js:982:23)
    at TablePage.assertColumnWidth (src/table/__integ__/resizable-columns.test.ts:124:5)
    at src/table/__integ__/resizable-columns.test.ts:347:5
    at src/table/__integ__/resizable-columns.test.ts:150:5
    at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)

Check warning on line 124 in src/table/__integ__/resizable-columns.test.ts

View workflow job for this annotation

GitHub Actions / dry-run / Components integration tests shards (React 16, shard 3/4)

RETRY 1: should recover column widths when the inner state is reset 

Column at index "2" should have width "130"

    at node_modules/webdriverio/build/node.js:6083:15
    at Browser.wrapCommandFn (node_modules/@wdio/utils/build/index.js:982:23)
    at TablePage.assertColumnWidth (src/table/__integ__/resizable-columns.test.ts:124:5)
    at src/table/__integ__/resizable-columns.test.ts:347:5
    at src/table/__integ__/resizable-columns.test.ts:150:5
    at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
timeout: 1000,
timeoutMsg: `Column at index "${columnIndex}" should have width "${expected}"`,
});
Expand All @@ -145,7 +145,7 @@
enableKeyboardNavigation:
config?.enableKeyboardNavigation !== undefined ? String(config.enableKeyboardNavigation) : 'false',
}).toString();
await browser.url(`#/light/table/resizable-columns?${params}`);
await browser.url(`#/table/resizable-columns?${params}`);
await page.waitForVisible(tableWrapper.findBodyCell(2, 1).toSelector());
await testFn(page);
});
Expand Down Expand Up @@ -341,8 +341,8 @@
test(
'should recover column widths when the inner state is reset',
setupTest(async page => {
await page.resizeColumn(2, 100);
const oldWidth = await page.getColumnWidth(2);
await page.resizeColumn(2, 100);
await page.click('#reset-state');
await page.assertColumnWidth(2, oldWidth);
})
Expand Down
Loading