fix(fuzzylist): reset list cursor on query change#32
Open
rodolfoinfantini wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue in the fuzzy list selection where typing a query would cause the second matching item in the list to be highlighted instead of the first one.
The Problem
When opening the fuzzy finder project selection:
0), the list cursor initially clamps to the first selectable row (at index1).0of the filtered list).l.cursor) remained at index1, the second matching item was selected instead of the top-ranked match.The Solution
lastQuery) infuzzyList.filter(), if the query has changed, the cursor (l.cursor) is reset back to0so that the first matched item is highlighted.TestFuzzyListQueryChangeResetsCursorinfuzzylist_test.goto verify this behavior and protect against future regressions.Closes #30